Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Modernize eprihlaska for 2024 #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrshu
Copy link
Contributor

@mrshu mrshu commented Jan 15, 2024

  • Track dependencies with Poetry

  • Bump the dependencies to 2024

  • Get rid of Facebook OAuth option

@mrshu mrshu requested review from Adman and tvinar January 15, 2024 06:01
@mrshu
Copy link
Contributor Author

mrshu commented Jan 15, 2024

@Adman @tvinar probably won't be merged before the end of 2024 season but we ought to be ready for the future, not the past (in which the dependencies are pinned for the archaic Python version 3.7.9).

Copy link
Member

@Adman Adman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -802,13 +801,13 @@ def create_or_get_user_and_login(site, token, name, surname, email):
@app.route('/google/login', methods=['GET'])
def google_login():
callback_uri = url_for('google_authorize', _external=True)
return google.authorize_redirect(callback_uri)
return oatuh.google.authorize_redirect(callback_uri)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, thanks @TomiBelan!

* Track dependencies with Poetry

* Bump the dependencies to 2024

* Get rid of Facebook OAuth option

Signed-off-by: mr.Shu <[email protected]>
@mrshu mrshu force-pushed the mrshu/eprihlaska-modernization branch from 96afd7e to 29e8e76 Compare February 12, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants